949525 - VP9 test files

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jan Gerber]

There should be a vp9 test file (content/media/vp9.webm) to test vp9 support.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should add two files to content/media/test/ that contain vp9+opus, a *short* one (duration around 0.5s) that is included in gSmallTests (in content/media/test/manifest.js), and a longer one (say around 5s) which we add to gPlayedTests.

Part of the reason that our mochitests take so long to run is that we have files that aren't short in gSmallTests. gSmallTests is meant to be used to test that the files can load or do a quick play through without stressing the decoders.

Comment 2

[Ralph Giles (:rillian)]

Attachment: vp9cake.webm

I propose vp9cake.webm for the longer test. vp9+opus, muxed with mkvmerge, 8 seconds, audio shorter than video, 139K.

Comment 3

[Jan Gerber]

Attachment: vp9.webm

0.5 seconds of cake

Comment 4

[Jan Gerber]

Attachment: 0001-Bug-949525-VP9-tests.patch

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8347172 [details] [diff] [review]
0001-Bug-949525-VP9-tests.patch

Review of attachment 8347172 [details] [diff] [review]:
-----------------------------------------------------------------

You need to `hg add` or equivalent the vp9.webm and vm9cake.webm files.

Comment 6

[Jan Gerber]

Attachment: 0001-Bug-949525-VP9-tests.patch

include webm files in patch, carrying forward review.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/689ec26f50e1

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/b1d1c9098751 for causing various assertions like https://tbpl.mozilla.org/php/getParsedLog.php?id=32056533&tree=B2g-Inbound

Comment 9

[Ralph Giles (:rillian)]

Attachment: remuxed vp9cake.webm

Turns out there's a bug in mkvmerge which I used to make the first version of vp9cake.webm. It (or we) still aren't completely correct, but this file is better, and doesn't assert during playback.

I filed bug 951770 about tightening our validity checking.

Comment 10

[Jan Gerber]

Attachment: 0001-Bug-949525-VP9-tests.patch

Updated patch to include the new vp9cake.webm and replace vp9.webm with a video only test based on seek.webm.

Comment 11

[Ralph Giles (:rillian)]

Green on try. Carrying forward r=cpeace.

https://tbpl.mozilla.org/?tree=Try&rev=091dbf933e1a

Comment 12

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9b4dbde503d

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a9b4dbde503d

Comment 14

[Mihaela Velimiroviciu (:mihaelav)]

Are there any more automated tests needed for this feature?

Comment 15

[Jan Gerber]

(In reply to Mihaela Velimiroviciu [QA] (:mihaelav) from comment #14)
> Are there any more automated tests needed for this feature?

not aware of any other tests that would be needed at this time.